-
-
Notifications
You must be signed in to change notification settings - Fork 28
Fix I2C permission issue on Fedora (#254) #261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix I2C permission issue on Fedora (#254) #261
Conversation
|
Rules shouldn't be installed to |
c794bdf to
d18c27e
Compare
- Change udev rules path from /usr/lib/udev to /etc/udev for proper precedence - Add KERNEL match to i2c-dev udev rule for better device detection - Enhance error handling in numberpad.py for permission errors - Ensure consistent INSTALL_UDEV_DIR_PATH across all scripts - Add directory creation for robustness in install scripts
d18c27e to
2cc7e7b
Compare
|
@kamack38 thanks for the feedback. Code is updated according to it. |
|
@s-badran Please do not include |
|
@s-badran Do you have concrete or theoretical experience about a situation when this directory is missing? Which distribution? I mean |
|
@s-badran Was changed udev rule tested? And permissions exception handling? Btw. I refactored the master branch to using |
Honestly, I don't have a reproducible Fedora instance where
I tested the rule locally on Ubuntu 24.04 ; installed the rule (as 55-...), reloaded rules with I added explicit I will rebase |
- Change udev rules path from /usr/lib/udev to /etc/udev for proper precedence - Add KERNEL match to i2c-dev udev rule for better device detection - Enhance error handling in numberpad.py for permission errors - Ensure consistent INSTALL_UDEV_DIR_PATH across all scripts - Add directory creation for robustness in install scripts
- Port PermissionError handling to periphery.I2C API - Keep udev rule priority changes (55- instead of 99-) - Maintain enhanced error messages for I2C permission issues
|
I figured I better have someone to test the fix on a fedora 43 OS, before submitting this PR. |
Related issue: #254